Making two changes so that quickumls_simstring can build again on Windows #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dows. Since Windows default locale encoding for open() is cp1252, the encoding for reading a file is now explicit as utf8. Also, there was a "unresolved external" link time error once the extension was changed to 'quickumls_simstring/_simstring' but is now set to '_simstring' for Windows.
…were being installed to install_dir instead of install_dir/quickumls_simstring which would prevent the lib from being found in Windows after install. Tried several other options to make this work but since the documentation for Extension says that the name of an extension should not be a filename (https://docs.python.org/3/distutils/apiref.html#distutils.core.Extension) this was the best solution I could find.
|
The first commit here allowed the runtime lib (_simstring) to be built under Windows, but the installation was still not correct. Since this lib is expected to be found under [install_dir]/quickumls_simstring, I made some modifications to ensure that the library gets installed there to work around the Extension name having a subdirectory in its name. Any questions on this one? I might host this update on a conda channel since we'd like to feature QuickUMLS in some upcoming medspacy presentations. |
…g up to a pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Windows default locale encoding for open() is cp1252, the encoding for reading a file is now explicit as utf8. Also, there was a "unresolved external" link time error once the extension was changed to 'quickumls_simstring/_simstring' but is now set to '_simstring' for Windows.
This was able to build on Windows before pip support was added but there were two errors after the commit for this (e5ff000).
If this is accepted, it would be great to bump the version number to enable Windows building again